Bug#887226: cloud-init should depend on e2fsprogs explicitly

[Helmut Grohne]

Package: cloud-init
Version: 0.7.9-5
User: ***@debian.org
Usertags: nonessentiale2fsprogs

Dear maintainer,

We want to make removing e2fsprogs from installations possible. For standard
installations this is not useful, but embedded applications and chroots benefit
from such an option. For getting there all packages that use e2fsprogs must be
identified and gain a dependency on it as e2fsprogs currently is essential.

cloud-init was identified as potentially needing such a dependency,
because it mentions tool names from e2fsprogs in the following files:

/usr/lib/python3/dist-packages/cloudinit/config/cc_resizefs.py contains resize2fs. According to file it is a Python script, ASCII text executable

Please investigate whether these cases are actually uses of a tool from
e2fsprogs. Care has been taken to shrink the number of candidates as much as
possible, but a few false positives will remain. After doing so, do one of the
following:

* Add e2fsprogs to Depends.
* Add e2fsprogs to Recommends.
* Close this bug explaining why e2fsprogs is not used by this package.

Once e2fsprogs drops the "Essential: yes" flag, this bug will be upgraded to RC
severity. Please note that lintian will warn about such a dependency before
lintian 2.5.56.

Thanks for your help

Helmut

[Andreas Henriksson]

Control: severity -1 minor
Control: retitle -1 cloud-init should consider suggesting e2fsprogs, btrfs-progs, xfsprogs, ...

Post by Helmut Grohne
Package: cloud-init

[...]

Post by Helmut Grohne
/usr/lib/python3/dist-packages/cloudinit/config/cc_resizefs.py contains resize2fs. According to file it is a Python script, ASCII text executable

[...]

A code snippet from cc_resizefs.py:
---->8-----8<------->8-----8<--------

def _resize_btrfs(mount_point, devpth):
return ('btrfs', 'filesystem', 'resize', 'max', mount_point)


def _resize_ext(mount_point, devpth):
return ('resize2fs', devpth)


def _resize_xfs(mount_point, devpth):
return ('xfs_growfs', devpth)


def _resize_ufs(mount_point, devpth):
return ('growfs', devpth)


# Do not use a dictionary as these commands should be able to be used
# for multiple filesystem types if possible, e.g. one command for
# ext2, ext3 and ext4.
RESIZE_FS_PREFIXES_CMDS = [
('btrfs', _resize_btrfs),
('ext', _resize_ext),
('xfs', _resize_xfs),
('ufs', _resize_ufs),
]

---->8-----8<------->8-----8<--------

Given that cloud-init package doesn't specify a relationship to any
of the other filesystem specific packages shipping resizing tools
I'm going to assume there's no need for e2fsprogs relationship either.
It probably wouldn't hurt to add atleast a Suggests for all of them
though....

Would be great to hear the maintainers view on this.

Regards,
Andreas Henriksson

[Debian Bug Tracking System]

Post by Andreas Henriksson
severity -1 minor

Bug #887226 [cloud-init] cloud-init should depend on e2fsprogs explicitly
Severity set to 'minor' from 'normal'

Post by Andreas Henriksson
retitle -1 cloud-init should consider suggesting e2fsprogs, btrfs-progs, xfsprogs, ...

Bug #887226 [cloud-init] cloud-init should depend on e2fsprogs explicitly
Changed Bug title to 'cloud-init should consider suggesting e2fsprogs, btrfs-progs, xfsprogs, ...' from 'cloud-init should depend on e2fsprogs explicitly'.

[Debian Bug Tracking System]

Your message dated Thu, 20 Sep 2018 21:04:15 +0000
with message-id <E1g367T-0001Iv-***@fasolo.debian.org>
and subject line Bug#887226: fixed in cloud-init 18.3-1
has caused the Debian Bug report #887226,
regarding cloud-init should consider suggesting e2fsprogs, btrfs-progs, xfsprogs, ...
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)